Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo ./rpiboot early exit without -d flag #228

Closed
polarbeared opened this issue Jul 4, 2024 · 0 comments
Closed

sudo ./rpiboot early exit without -d flag #228

polarbeared opened this issue Jul 4, 2024 · 0 comments

Comments

@polarbeared
Copy link

Describe the bug

There's an early exit in the main.c when it checks for whether the -d directory flag is present.

If a user tries to run the usbboot program to get the raspberry pi into mass storage mode by running sudo ./rpiboot, directory (flag -d) will be equal to NULL, and the program will exit.

Steps to reproduce the behaviour

command: sudo ./rpiboot
result: RPIBOOT: build-date Jul 4 2024 version 20240422~085300 17b5a351 Waiting for BCM2835/6/7/2711/2712... Directory '(null)' does not exist

Device(s)

Raspberry Pi CM4

Compute Module IO board.

No response

RPIBOOT logs

No response

Kernel logs

No response

Device UART logs

No response

@polarbeared polarbeared changed the title sudo ./rpiboot is broken sudo ./rpiboot early exit without -d flag Jul 4, 2024
martamomotko added a commit to martamomotko/usbboot that referenced this issue Jul 5, 2024
rpiboot: Minor code style and spelling fix

rpiboot: Update to check if directory exists

rpiboot: Moved directory existence check

rpiboot: Fixed early exit without -d flag. Fixes raspberrypi#228
martamomotko added a commit to martamomotko/usbboot that referenced this issue Jul 5, 2024
rpiboot: Removed directory existence check. Fixes raspberrypi#228

bootfiles: Add error check for file open operation
martamomotko added a commit to martamomotko/usbboot that referenced this issue Jul 5, 2024
rpiboot: Removed directory existence check. Fixes raspberrypi#228

bootfiles: Add error check for file open operation
martamomotko added a commit to martamomotko/usbboot that referenced this issue Jul 5, 2024
rpiboot: Removed directory existence check. Fixes raspberrypi#228

bootfiles: Add error check for file open operation
@timg236 timg236 closed this as completed in 2367b79 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant