Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel 1.3.8.post1 #110

Merged
merged 24 commits into from
Oct 10, 2023
Merged

Rel 1.3.8.post1 #110

merged 24 commits into from
Oct 10, 2023

Conversation

sgillies
Copy link
Member

No description provided.

@sgillies
Copy link
Member Author

Reverting to Cython < 3 didn't work. I still see the segmentation fault in test_compdcs.

@sgillies
Copy link
Member Author

Hold on, Windows wheels tests passed for Python 3.8-3.11 after reverting to Cython 0.29: https://github.com/rasterio/rasterio-wheels/actions/runs/6237503716.

@sgillies
Copy link
Member Author

@snowman2 thanks for spotting the problem! Indeed, removing the extra instance of _matches prevents the segmentation fault on Linux. I'm testing Windows now.

@snowman2
Copy link
Member

@snowman2 thanks for spotting the problem! Indeed, removing the extra instance of _matches prevents the segmentation fault on Linux. I'm testing Windows now.

I am glad that it addressed the issue. That one was a challenge to find 😀

@sgillies sgillies changed the title Rel 1.3.8 Rel 1.3.8.post1 Oct 2, 2023
@sgillies sgillies mentioned this pull request Oct 9, 2023
@sgillies sgillies merged commit d5b61f9 into main Oct 10, 2023
0 of 16 checks passed
@sgillies sgillies deleted the rel-1.3.8 branch October 10, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants