Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fileSync): must honor detachDescriptor and discardDescriptor options #149

Merged
merged 1 commit into from
Aug 12, 2017
Merged

fix(fileSync): must honor detachDescriptor and discardDescriptor options #149

merged 1 commit into from
Aug 12, 2017

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Jul 15, 2017 •
edited
Loading

fix #148

@silkentrance silkentrance mentioned this pull request Jul 15, 2017
Merged
3 tasks
@silkentrance silkentrance requested a review from raszi July 18, 2017 21:36
@silkentrance
Copy link
Collaborator Author

silkentrance commented Jul 19, 2017 •
edited
Loading

@raszi I think that we can merge this one. However, it would require a new release on npm. I already bumped the version to 0.0.33. Reverted that to 0.0.32 as the latest on npmjs.com is 0.0.31.

@silkentrance silkentrance mentioned this pull request Jul 19, 2017
Merged
@silkentrance silkentrance self-assigned this Jul 25, 2017
@raszi raszi merged commit fb3801a into master Aug 12, 2017
@silkentrance silkentrance deleted the gh-148 branch August 16, 2017 19:42
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
@raszi raszi changed the title fileSync must honor detachDescriptor and discardDescriptor options fix: fileSync must honor detachDescriptor and discardDescriptor options Aug 29, 2018
@raszi raszi changed the title fix: fileSync must honor detachDescriptor and discardDescriptor options fix(fileSync): must honor detachDescriptor and discardDescriptor options Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raszi raszi Awaiting requested review from raszi

Assignees

@silkentrance silkentrance

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fileSync does not implement discardDescriptor nor detachDescriptor
2 participants
@silkentrance @raszi