Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): simplify the CODEOWNERS file #271

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Jun 18, 2023

Auto review-requests were not working so let's try this way.

@orhun orhun requested a review from joshka as a code owner June 18, 2023 22:15
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #271 (4f41f0f) into main (130bdf8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files          35       35           
  Lines        7197     7197           
=======================================
  Hits         5929     5929           
  Misses       1268     1268           

@joshka
Copy link
Member

joshka commented Jun 19, 2023

Ha yep:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

@joshka joshka added this pull request to the merge queue Jun 19, 2023
Merged via the queue into ratatui:main with commit 284b0b8 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants