-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split CI job. Run formatting task on nightly. #278
Conversation
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 82.50% 82.73% +0.22%
==========================================
Files 36 36
Lines 7301 7360 +59
==========================================
+ Hits 6024 6089 +65
+ Misses 1277 1271 -6 |
What is the reasoning behind using the nightly toolchain for formatting? |
The current |
eaa655f
to
bff3215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approve this change. Using the new install action is a nice to have that will probably speed up installing cargo-make however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as suggestions so I can commit them straight up and check the speed increase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh - space
f441b9b
to
35c2318
Compare
Getting yaml perfectly right in the browser is fiddly (spacing matters), so I pulled it down and made the changes locally. I've force pushed to your branch - which should be correct now. I updated the commit message to fit the conventional commit style too. |
Install time drops to 1-2s on Mac / linux and 6-8s on window from 2-4 minutes previously. (compare https://github.com/tui-rs-revival/ratatui/actions/runs/5372360022/jobs/9745700496?pr=277) |
That's great |
The PR was merged into install-action, so I bumped this to: - name: Install cargo-make
uses: taiki-e/install-action@cargo-make |
- Split CI into build, clippy and test. - Run format on nightly only due to the settings being unstable
35c2318
to
a831627
Compare
set formatting task to use nightly toolchain, create new task style-check, and split CI job into build, test, and Clippy - make them depend on style-checks
#194