-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(canvas): add support note for Braille marker #472
Conversation
Pinging @relf for input |
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 40 40
Lines 11166 11166
=======================================
Hits 10057 10057
Misses 1109 1109
|
I wonder should we link to some fonts that support this? Otherwise LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The thing is, discovering |
Should we also add a one line text description to the Something like "Requires terminal and font support for unicode". |
I'd be more inclined to suggest that whatever we do with demos should generally look good out of the box for a default configuration, so perhaps we should switch to dots instead of braille for the main demo and introduce the braille markers later? |
Yes this seems like a good idea to me. |
Yes that was my first thought but I did not dare to suggest it (more involved changes), but now that you say it... |
Perhaps a wiki page might be appropriate for this? |
Addresses #457