chore: Prevent PR merge with do not merge labels
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdheepak
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
joshka
as code owners
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 41 41
Lines 11277 11277
=======================================
Hits 10168 10168
Misses 1109 1109 |
kdheepak
force-pushed
the
do-not-merge-action
branch
from
5c5bd9a
to
763a83f
Compare
|
With the current title of this PR, the check-breaking-change-label step will fail; but this PR will fix it and going forward this won't be an issue. So this PR can be merged even if that step fails. |
joshka
approved these changes
Sep 10, 2023
orhun
reviewed
Sep 10, 2023
| pattern='^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\(\w+\))?!:' | ||
| if echo "$title" | grep -qE "$pattern"; then | ||
| # Check if pattern matches | ||
| if echo "${{ github.event.pull_request.title }}" | grep -qE "$pattern"; then |
There was a problem hiding this comment.
We could probably do something like this here:
if [[ "${{ github.event.pull_request.title }}" =~ $pattern ]]; then
But I'm too late for the review, can you guys wait a bit before merge?
There was a problem hiding this comment.
Sorry about that! Next time I'll wait longer for merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents merges if a
do not mergelabel is added on GitHub.This PR also fixes an issue that allows checking PR titles with backticks in the title string.