Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): add automated nightly releases #359

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Jul 31, 2023

As discussed in the last meeting, this PR updates the release workflow (cd.yml) for creating periodic nightly releases.

The version schema is <version>-alpha.<num> and <num> is increased each time the workflow runs. It is also possible to trigger a nightly release manually via the GitHub interface (see workflow_dispatch).

Tested here: https://github.com/orhun/tui-rs-revival/tags

Closes #147

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #359 (1daf6be) into main (440f62f) will increase coverage by 0.23%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   84.76%   84.99%   +0.23%     
==========================================
  Files          40       40              
  Lines        8603     8686      +83     
==========================================
+ Hits         7292     7383      +91     
+ Misses       1311     1303       -8     

see 2 files with indirect coverage changes

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semver suggests that 0.22.0-whatever is before 0.22.0. We should go to 0.22.1-alpha.0 from 0.22.0.

Otherwise, looks good.

.github/workflows/cd.yml Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ααα

@orhun orhun added this pull request to the merge queue Aug 5, 2023
Merged via the queue into ratatui:main with commit aad164a Aug 5, 2023
30 checks passed
@joshka joshka added this to the v0.23.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly releases
4 participants