feat(table): allow page up/down in table #4
Conversation
joshka
added
the
Type: Imported from tui-rs
joshka
force-pushed
the
246/demonstrate-paging-in-table
branch
from
5d813f6
to
14fed0c
Compare
|
Rebased on main and this runs. This works the same as the implementation in tui for this change did, but the behavior seems a little odd. Hitting page down when row 0 is selected with rows 0-13 showing on the screen makes item 1-14 shown on the screen with row 14 selected (and similarly page up when row 14 is selected goes to 0. I think the more obvious behavior might to display rows 14-27 when paging down and have 14 be the selected row. Additionally, the wrap around behavior seems odd. Going page up from row 0 shows rows 73 to 86, numerically correct, but would be odd from a user's perspective as it makes rows 87-99 effectively invisible. Or put another way:
I might be wrong on this though, so please feel free to correct me, but it took a bit of effort to understand what was going on with this and build a mental model just from using it where the selected item would end up. I think this is a reasonable feature if the behavior is fixed to properly show all rows without skipping displaying any, and by scrolling by a page rather than an index. Pinging @Eosis to see if they want to pick this up and complete the feature (and marking it as up for grabs / draft if not) |
joshka
added
the
Status: Available
- Add a page_size to the Table widget's state that is populated when the table is rendered and allows users to scroll the cursor in the table much more quickly. - Alter the table example to demonstrate potential paging behaviour - Add new next and previous page functions to demonstrate moving a selection by page. - Automatically generate the data for the table as a Vec<Vec<String>>.
joshka
force-pushed
the
246/demonstrate-paging-in-table
branch
from
14fed0c
to
00b4b7a
Compare
joshka
changed the title
|
This issue was closed due to it becoming stale. Feel free to reopen and work on this. |
NOTE FOR IMPLEMENTER: Please read the following before picking this up for implementation:
Hi!
I started playing with the table example and though that for bigger tables it would be nice to be able to scroll the data a page at a time, so I altered the
Tablewidget'sTableStateto store a page size for the table and itsrenderfunction to update this at the relevant point. I have also updated the example for theTablewidget to use this.Let me know if you think this is a good addition or any other feedback. 😁