Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): fix panic when rendering out of bounds #997

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Mar 25, 2024

Previously it was possible to cause a panic when rendering to an area
outside of the buffer bounds. Instead this now correctly renders nothing
to the buffer.

Previously it was possible to cause a panic when rendering to an area
outside of the buffer bounds. Instead this now correctly renders nothing
to the buffer.
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.3%. Comparing base (8719608) to head (4ca7f48).

Files Patch % Lines
src/text/line.rs 75.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #997     +/-   ##
=======================================
- Coverage   89.3%   89.3%   -0.1%     
=======================================
  Files         61      61             
  Lines      15295   15298      +3     
=======================================
+ Hits       13668   13670      +2     
- Misses      1627    1628      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka merged commit 742a5ea into main Mar 25, 2024
33 checks passed
@joshka joshka deleted the fix-text-render-out-of-bounds branch March 25, 2024 05:06
joshka added a commit to nowNick/ratatui that referenced this pull request May 24, 2024
Previously it was possible to cause a panic when rendering to an area
outside of the buffer bounds. Instead this now correctly renders nothing
to the buffer.
joshka added a commit to erak/ratatui that referenced this pull request Oct 14, 2024
Previously it was possible to cause a panic when rendering to an area
outside of the buffer bounds. Instead this now correctly renders nothing
to the buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants