Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homunculus Re-sync with kro Tables and Updates[missing updates] #8114

Closed
wants to merge 34 commits into from

Conversation

AoShinRO
Copy link
Contributor

@AoShinRO AoShinRO commented Jan 20, 2024

  • Addressed Issue(s):
  • Server Mode: Renewal
  • Description of Pull Request:

[07/07/11]
updating renewal homunculus stats formulas [Newer Formulas are based on it with little changes]

ATK  = Floor((STR + DEX + LUK) ÷ 3) + Floor(Level ÷ 10)
MATK = (Level + INT + Floor((INT + DEX + LUK) ÷ 3) + Floor(Level ÷ 10)) × 2
HIT  = Level + DEX + 150
CRI  = Floor(LUK ÷ 3) + 1
DEF  = (VIT + Floor(Level ÷ 10)) × 2 + Floor((AGI + Floor(Level ÷ 10)) ÷ 2) + Floor(Level ÷ 2)
MDEF = (VIT + Floor(Level ÷ 10))  + Floor((INT + Floor(Level ÷ 10)) ÷ 4) + Floor(Level ÷ 4)
FLEE = Level + AGI + Floor(Level ÷ 10)

image

according to
http://ww4.enjoy.ne.jp/~to4/R/hom.html
https://irowiki.org/wiki/Homunculus_System

Added Updt [March 3, 2019]

 Increases physical and magical damage of homunculus.

according to ->
https://www.divine-pride.net/forum/index.php?/topic/3723-kro-jobs-improvement-project/&do=findComment&comment=5516

Newer Growthing Tables -> [May 27, 2020]

- Increases bonus HP and SP gained from raising base level of basic homunculus.
- Increases bonus HP and SP gained from evolving homunculus.
- Increases bonus HP and SP gained from raising base level of homunculus S.
- Increases bonus HP and SP gained from changing homunculus to homunculus S.
(The HP and SP increasing effects only apply to new homunculi that are created after this update).

according to:
https://www.divine-pride.net/forum/index.php?/topic/3723-kro-jobs-improvement-project/&do=findComment&comment=7644
https://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7288&curpage=33

image

ToDo->

  • Confirm Homunc S new Growthing HP & SP Tbl
  • Adjust new SP Growthing tables

Added most aproximated value for Homun_F_Tablet
according to -> https://www.youtube.com/watch?v=DUJzfcSPnRI

[BugFix~]Homun SP e Max SP always showed with 100 value when you reach 32k+ SP, packet and cliend actually supports higher values then INT16_MAX, capping to INT32_MAX/100 now

@AoShinRO AoShinRO changed the title base-hom-missing-updt + smallfix Base Homunculus Skill Cooldown + New Homunculus Growthing Table [missing updts] Jan 24, 2024
@AoShinRO AoShinRO marked this pull request as draft January 24, 2024 14:56
@AoShinRO AoShinRO marked this pull request as ready for review January 24, 2024 18:51
@AoShinRO AoShinRO changed the title Base Homunculus Skill Cooldown + New Homunculus Growthing Table [missing updts] Homunculus Re-sync with kro Tables and Updates[missing updates] Jan 25, 2024
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
db/re/item_db_usable.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@aleos89 aleos89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General cleanup to reduce repeated code.

src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
@AoShinRO AoShinRO marked this pull request as draft February 2, 2024 14:09
@AoShinRO AoShinRO marked this pull request as ready for review February 3, 2024 13:12
Copy link
Member

@Daegaladh Daegaladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the homunculus cooldowns have been fixed in 3908b0e, the related changes can be removed from here

@AoShinRO
Copy link
Contributor Author

AoShinRO commented Aug 15, 2024

Since the homunculus cooldowns have been fixed in 3908b0e, the related changes can be removed from here

When I get some time I'll take a look
ty for info

Edit-> Done!

@AoShinRO AoShinRO closed this Sep 3, 2024
@Daegaladh
Copy link
Member

Why did you close it?

@AoShinRO
Copy link
Contributor Author

AoShinRO commented Sep 3, 2024

Why did you close it?

because it have a lot of conflicts with main branch now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants