Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted ZC_CHANGE_CHATROOM to struct #8589

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Converted ZC_CHANGE_CHATROOM to struct #8589

merged 5 commits into from
Sep 12, 2024

Conversation

AoShinRO
Copy link
Contributor

  • Addressed Issue(s):
  • Server Mode: both
  • Description of Pull Request: Converted ZC_CHANGE_CHATROOM to struct

Lemongrass3110
Lemongrass3110 approved these changes Sep 2, 2024
View reviewed changes
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.hpp Outdated Show resolved Hide resolved
src/map/packets.hpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
src/map/clif.cpp Outdated Show resolved Hide resolved
@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:maintenance Issue for refactoring rAthena labels Sep 2, 2024
AoShinRO and others added 2 commits September 2, 2024 22:31
@AoShinRO @Lemongrass3110
Apply suggestions from code review
cb8467f 
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
@AoShinRO @Lemongrass3110
Apply suggestions from code review
ea17678 
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
aleos89
aleos89 approved these changes Sep 3, 2024
View reviewed changes
src/map/clif.cpp Outdated Show resolved Hide resolved
AoShinRO and others added 2 commits September 3, 2024 10:30
@AoShinRO @aleos89
Update src/map/clif.cpp
927e2ef 
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
@AoShinRO
Merge branch 'master' into PACKET_ZC_CHANGE_CHATROOM
67de9ae
@aleos89 aleos89 merged commit c4b77f1 into rathena:master Sep 12, 2024
31 checks passed
sammeepay added a commit to sammeepay/rathena-edit-custom-npcthai that referenced this pull request Sep 12, 2024
@sammeepay
Converted ZC_CHANGE_CHATROOM to struct (rathena#8589)
78a150d 
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Converted ZC_REQ_EXCHANGE_ITEM&ZC_ACK_EXCHANGE_ITEM to struct (rathena#8581)
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Converted ZC_REQ_TAKEOFF_EQUIP_ACK to struct (rathena#8580)
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Corrected Spore Explosion and Earth Shaker skills effect (rathena#8611)
Fixed UNT_JACK_FROST_NOVA and UNT_GROUND_GRAVITATION (rathena#8619)
* Added missing UNT_JACK_FROST_NOVA and UNT_GROUND_GRAVITATION in skill_unit_onplace_timer
(damage over time were missing)
sammeepay added a commit to rAthena-Thailand/rathenaThailand that referenced this pull request Sep 12, 2024
@sammeepay
Converted ZC_CHANGE_CHATROOM to struct (rathena#8589)
b730c07 
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Converted ZC_REQ_EXCHANGE_ITEM&ZC_ACK_EXCHANGE_ITEM to struct (rathena#8581)
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Converted ZC_REQ_TAKEOFF_EQUIP_ACK to struct (rathena#8580)
---------
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Corrected Spore Explosion and Earth Shaker skills effect (rathena#8611)
Fixed UNT_JACK_FROST_NOVA and UNT_GROUND_GRAVITATION (rathena#8619)
* Added missing UNT_JACK_FROST_NOVA and UNT_GROUND_GRAVITATION in skill_unit_onplace_timer
(damage over time were missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemongrass3110 Lemongrass3110 Lemongrass3110 approved these changes

@aleos89 aleos89 aleos89 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:maintenance Issue for refactoring rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AoShinRO @Lemongrass3110 @aleos89