Avoid [Error] division by zero detected #8672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user enters input too quickly, the following error will occur: [Error]: script:op_2num: division by zero detected op=C_DIV i1=1300 i2=0 To prevent the player from getting stuck and having to force close the client, add an if statement.
AoShinRO
reviewed
Sep 22, 2024
Co-authored-by: AoShinHo <126742159+AoShinRO@users.noreply.github.com>
aleos89
approved these changes
Sep 23, 2024
Atemo
added
component:script
sammeepay
added a commit
to rAthena-Thailand/rathenaThailand
that referenced
this pull request
Oct 3, 2024
Corrected 12462/12463/12464/12465 item scripts (SC_ already implemented)…… (rathena#8696) Fixed rathena#8413 Added missing MATK % per level of AG_TWOHANDSTAFF for 2hstaff weapon (……rathena#8694) Fixed rathena#8693 Disable RG_CLOSECONFINE against Boss monsters (rathena#8684) * Fixes rathena#8555. * Close Confine will no longer apply the status when used against Boss monsters. Thanks to @jamesandrewww! Corrected MSI_IMPOSSIBLE_SKILL_AREA color (rathena#8681) * MSI_IMPOSSIBLE_SKILL_AREA Should appears in Cyan color instead of White Fixed Vanilmirth skills + NPC_SELFDESTRUCTION (rathena#8650) Co-authored-by: Lemongrass3110 <lemongrass@kstp.at> Implemented statuses SC_BATH_FOAM_A, SC_BATH_FOAM_B, SC_BATH_FOAM_C (……rathena#8688) Fixed NPC Secure Timeout cutin (rathena#8683) * NPC shouldn't clear the script after the timeout has passed. and should clear the cutin Fixed Dimen_WH_C_Bow (700093) combo rate (rathena#8691) * Fixed incorrect ChaseRange value for MD_E_13EN0 (rathena#8692) caused by rathena@e803ba5 Moved S.matk and skillratio formula after battle_calc_cardfix (rathena#8690) Fixed rathena#8689 Fixed missing OverlapIgnoreLevel climax status (rathena#8687) Without this status the status would fail when casting a skill of a level lower than the active status. On official server, Climax can be recasted regardless of the current status level. Add missing import file (rathena#8674) * Add the reputation group import file not being created from MSVS. Implemented new items up to September 17, 2024 (rathena#8655) * Updated hateffects Fixed a possible division by zero in npc/airports/airships.txt (rathena#8672) Fixed Item Sealed Aquatic Spear subType (rathena#8675)
sammeepay
added a commit
to sammeepay/rathena-edit-custom-npcthai
that referenced
this pull request
Oct 3, 2024
Corrected 12462/12463/12464/12465 item scripts (SC_ already implemented)…… (rathena#8696) Fixed rathena#8413 Added missing MATK % per level of AG_TWOHANDSTAFF for 2hstaff weapon (……rathena#8694) Fixed rathena#8693 Disable RG_CLOSECONFINE against Boss monsters (rathena#8684) * Fixes rathena#8555. * Close Confine will no longer apply the status when used against Boss monsters. Thanks to @jamesandrewww! Corrected MSI_IMPOSSIBLE_SKILL_AREA color (rathena#8681) * MSI_IMPOSSIBLE_SKILL_AREA Should appears in Cyan color instead of White Fixed Vanilmirth skills + NPC_SELFDESTRUCTION (rathena#8650) Co-authored-by: Lemongrass3110 <lemongrass@kstp.at> Implemented statuses SC_BATH_FOAM_A, SC_BATH_FOAM_B, SC_BATH_FOAM_C (……rathena#8688) Fixed NPC Secure Timeout cutin (rathena#8683) * NPC shouldn't clear the script after the timeout has passed. and should clear the cutin Fixed Dimen_WH_C_Bow (700093) combo rate (rathena#8691) * Fixed incorrect ChaseRange value for MD_E_13EN0 (rathena#8692) caused by rathena@e803ba5 Moved S.matk and skillratio formula after battle_calc_cardfix (rathena#8690) Fixed rathena#8689 Fixed missing OverlapIgnoreLevel climax status (rathena#8687) Without this status the status would fail when casting a skill of a level lower than the active status. On official server, Climax can be recasted regardless of the current status level. Add missing import file (rathena#8674) * Add the reputation group import file not being created from MSVS. Implemented new items up to September 17, 2024 (rathena#8655) * Updated hateffects Fixed a possible division by zero in npc/airports/airships.txt (rathena#8672) Fixed Item Sealed Aquatic Spear subType (rathena#8675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user enters input too quickly, the following error will occur:
[Error]: script:op_2num: division by zero detected op=C_DIV i1=1300 i2=0
To prevent the player from getting stuck and having to force close the client, add an if statement.
BOTH