Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update document about install ratify on azure policy enabled aks cluster #1041

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

fseldow
Copy link
Contributor

@fseldow fseldow commented Aug 29, 2023

Description

What this PR does / why we need it:

update ratify-on-azure about how to install ratify on aks cluster

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1001

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be6be88) 58.32% compared to head (decbd52) 58.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files          93       93           
  Lines        5543     5543           
=======================================
  Hits         3233     3233           
  Misses       1994     1994           
  Partials      316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fseldow fseldow changed the title update document about install ratify on azure policy enabled aks cluster [feat] update document about install ratify on azure policy enabled aks cluster Aug 29, 2023
@akashsinghal akashsinghal changed the title [feat] update document about install ratify on azure policy enabled aks cluster feat: update document about install ratify on azure policy enabled aks cluster Aug 30, 2023
@akashsinghal akashsinghal changed the title feat: update document about install ratify on azure policy enabled aks cluster doc: update document about install ratify on azure policy enabled aks cluster Aug 30, 2023
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, we can also sync up offline to add context around azure policy. thanks!

@@ -127,7 +127,8 @@ Configure user-assigned managed identity and enable `AcrPull` role to the worklo
--object-id ${IDENTITY_OBJECT_ID}
```

## Deploy Gatekeeper and Ratify on AKS
## Deploy Gatekeeper and Ratify on AKS
### When Azure Policy Addon is not enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need some context around What is a Azure policy addon, when would the customer need it.etc . audience maybe not be familiar with azure policy addon

docs/quickstarts/ratify-on-azure.md Outdated Show resolved Hide resolved
@susanshi susanshi enabled auto-merge (squash) September 7, 2023 01:12
@susanshi susanshi merged commit 40834b6 into ratify-project:main Sep 7, 2023
18 of 19 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
… cluster (ratify-project#1041)

Co-authored-by: Susan Shi <huish@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update doc about install ratify in azure policy addon enabled AKS cluster
2 participants