-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update document about install ratify on azure policy enabled aks cluster #1041
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 58.32% 58.32%
=======================================
Files 93 93
Lines 5543 5543
=======================================
Hits 3233 3233
Misses 1994 1994
Partials 316 316 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, we can also sync up offline to add context around azure policy. thanks!
@@ -127,7 +127,8 @@ Configure user-assigned managed identity and enable `AcrPull` role to the worklo | |||
--object-id ${IDENTITY_OBJECT_ID} | |||
``` | |||
|
|||
## Deploy Gatekeeper and Ratify on AKS | |||
## Deploy Gatekeeper and Ratify on AKS | |||
### When Azure Policy Addon is not enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need some context around What is a Azure policy addon, when would the customer need it.etc . audience maybe not be familiar with azure policy addon
… cluster (ratify-project#1041) Co-authored-by: Susan Shi <huish@microsoft.com>
Description
What this PR does / why we need it:
update ratify-on-azure about how to install ratify on aks cluster
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1001
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change