-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add namespace to external data request key #1201
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 55.13% 55.13% -0.01%
==========================================
Files 104 104
Lines 6879 6894 +15
==========================================
+ Hits 3793 3801 +8
- Misses 2753 2758 +5
- Partials 333 335 +2 ☔ View full report in Codecov by Sentry. |
1389e49
to
a44c592
Compare
8094c5a
to
ee0052f
Compare
4e10a63
to
afd5361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment. thanks!
Description
What this PR does / why we need it:
Adding a namespace field to the external data request key.
The current key is the image that needs to be validated. For multi-tenancy model, Ratify requires users provide both image and namespace that would be deployed to.
The new key would look like: [namespaceA]testRegistry/testRepo:v1
And this change is backward-compatible, so the original single image is supported.
Futhermore, once we fully support multi-tenancy model, requests without namespaces would be regarded as validation per cluster-wide instead of namespaced.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Part of issue: #743
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change