-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cache isolation #1213
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 55.31% 55.40% +0.09%
==========================================
Files 104 105 +1
Lines 6902 6916 +14
==========================================
+ Hits 3818 3832 +14
Misses 2749 2749
Partials 335 335 ☔ View full report in Codecov by Sentry. |
7c72f49
to
0b0d6af
Compare
0b0d6af
to
1b0ea3f
Compare
Signed-off-by: Binbin Li <libinbin@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What this PR does / why we need it:
namespace
throughcontext
so thatnamespace
can be consumed by all components in a request.namespace
to the cache key so that cache can be isolated by namespace.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Part of issue: #743
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change