Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update deployment template azure workload identity annotation #1320

Conversation

akashsinghal
Copy link
Collaborator

Description

What this PR does / why we need it

The existing helm chart would only inject the azure workload identity annotation if the ORAS auth provider was enabled. There are scenarios where AKV cert provider is used independently of the auth provider. This change updates the template condition to inject the annotation if the azureWorkloadIdentity.clientId is set. Now workload identity will be correctly set up if akv cert provider or oras auth provider is enabled independently. This annotation is required so the workload identity controller injects the necessary env variables + jwt token in the pod + container.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.73%. Comparing base (45c0f81) to head (a2e4ba7).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   61.60%   64.73%   +3.13%     
==========================================
  Files          98       98              
  Lines        6248     5059    -1189     
==========================================
- Hits         3849     3275     -574     
+ Misses       2066     1444     -622     
- Partials      333      340       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal akashsinghal marked this pull request as ready for review March 1, 2024 02:34
@akashsinghal akashsinghal enabled auto-merge (squash) March 1, 2024 02:35
@akashsinghal akashsinghal self-assigned this Mar 1, 2024
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akashsinghal akashsinghal merged commit 04b8cb8 into ratify-project:main Mar 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants