Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update azure tenantId casing #1385

Merged

Conversation

akashsinghal
Copy link
Collaborator

Description

What this PR does / why we need it:

Previous PR introduced a new azurekeyvault field to encompass all cert + key operations. The casing of the values.yaml file changed from tenantId to tenantID which is inconsistent with other values.yaml. This change reverts this change back to tenantId. This should lead to AKS e2e tests to pass.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (73ef709) to head (6b4bf59).
Report is 8 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1385      +/-   ##
===========================================
+ Coverage    65.31%   65.41%   +0.10%     
===========================================
  Files          105      107       +2     
  Lines         5458     5552      +94     
===========================================
+ Hits          3565     3632      +67     
- Misses        1535     1565      +30     
+ Partials       358      355       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -60,7 +60,7 @@ azureManagedIdentity:
azurekeyvault:
enabled: false
vaultURI:
tenantID:
tenantId:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this casing consistent with ClientId?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is consistent casing for the clientId in the values file. The existing tenantId under akvCertConfig also was the same casing. The CRD fields use a different casing of ID though but I thought we should remain consistent with other fields in values.yaml

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a clarification for ClientId, not a blocker for this PR to fix the aks test.

Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@akashsinghal akashsinghal merged commit 8acd52b into ratify-project:staging Apr 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants