-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update azure tenantId casing #1385
fix: update azure tenantId casing #1385
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #1385 +/- ##
===========================================
+ Coverage 65.31% 65.41% +0.10%
===========================================
Files 105 107 +2
Lines 5458 5552 +94
===========================================
+ Hits 3565 3632 +67
- Misses 1535 1565 +30
+ Partials 358 355 -3 ☔ View full report in Codecov by Sentry. |
@@ -60,7 +60,7 @@ azureManagedIdentity: | |||
azurekeyvault: | |||
enabled: false | |||
vaultURI: | |||
tenantID: | |||
tenantId: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this casing consistent with ClientId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is consistent casing for the clientId in the values file. The existing tenantId under akvCertConfig also was the same casing. The CRD fields use a different casing of ID though but I thought we should remain consistent with other fields in values.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a clarification for ClientId, not a blocker for this PR to fix the aks test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the fix
Description
What this PR does / why we need it:
Previous PR introduced a new
azurekeyvault
field to encompass all cert + key operations. The casing of thevalues.yaml
file changed fromtenantId
totenantID
which is inconsistent with other values.yaml. This change reverts this change back totenantId
. This should lead to AKS e2e tests to pass.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change