-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update cosign chart and remove extra logs #1475
fix: update cosign chart and remove extra logs #1475
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1475 +/- ##
==========================================
+ Coverage 66.76% 68.17% +1.41%
==========================================
Files 116 119 +3
Lines 6030 6137 +107
==========================================
+ Hits 4026 4184 +158
+ Misses 1620 1559 -61
- Partials 384 394 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
looks like a cosign test is failing. |
updated the chart to fix cosign failing test |
Co-authored-by: Binbin Li <libinbin@microsoft.com> Signed-off-by: akashsinghal <akashsinghal@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Description
What this PR does / why we need it:
key
field. The cosign verifier expects an absolute file path in thekey
field and not the contents directly. This is because the valuecosign.key
passed in via helm chart is translated to a secret that is then mounted to a well known path in the Ratify container. Cosign verifier loads this key directly via a file path provided in thekey
field. This behavior is the legacy one but for backwards compatibility we must support it.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
cosign.key
value. Then performed an upgrade to latest dev branch bits with same helm values and made sure verification of cosign sig continues to succeed.Checklist:
Post Merge Requirements
Helm Chart Change