Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cosign chart and remove extra logs #1475

Merged
merged 3 commits into from
May 15, 2024

Conversation

akashsinghal
Copy link
Collaborator

Description

What this PR does / why we need it:

  • removes extra logging statement added during development
  • updates cosign verifier helm chart template to specify a well-known path for key field. The cosign verifier expects an absolute file path in the key field and not the contents directly. This is because the value cosign.key passed in via helm chart is translated to a secret that is then mounted to a well known path in the Ratify container. Cosign verifier loads this key directly via a file path provided in the key field. This behavior is the legacy one but for backwards compatibility we must support it.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • locally installed v1.1.1 using helmfile.yaml with extra fields such as cosign.key value. Then performed an upgrade to latest dev branch bits with same helm values and made sure verification of cosign sig continues to succeed.

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (1bd347c) to head (8951d2a).
Report is 27 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1475      +/-   ##
==========================================
+ Coverage   66.76%   68.17%   +1.41%     
==========================================
  Files         116      119       +3     
  Lines        6030     6137     +107     
==========================================
+ Hits         4026     4184     +158     
+ Misses       1620     1559      -61     
- Partials      384      394      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

susanshi
susanshi previously approved these changes May 14, 2024
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

binbin-li
binbin-li previously approved these changes May 15, 2024
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@binbin-li binbin-li enabled auto-merge (squash) May 15, 2024 10:56
@binbin-li
Copy link
Collaborator

looks like a cosign test is failing.

@akashsinghal akashsinghal dismissed stale reviews from susanshi and binbin-li via 8951d2a May 15, 2024 18:22
@akashsinghal
Copy link
Collaborator Author

looks like a cosign test is failing.

updated the chart to fix cosign failing test

@binbin-li binbin-li merged commit 8834734 into ratify-project:dev May 15, 2024
17 checks passed
akashsinghal added a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: akashsinghal <akashsinghal@microsoft.com>
binbin-li added a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants