Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resolving tag to digest in the store interface #77

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

mnltejaswini
Copy link
Contributor

  • Added a method in store interface to resolve tag to digest. Fixes Support Tag to Digest resolution #74
  • All stores are iterated till a store resolves the tag without any error. If all stores fail to resolve, error is returned.
  • Updated tests and added new tests for this method
  • Added a command resolve that can be to resolve the tag and for debugging purposes
  • Updated the store specification with this new method.
  • Updated readme.md to use ratify with $IMAGE

With this change, ratify can now be used to verify with tag

ratify verify -s $IMAGE

Signed-off-by: Tejaswini Duggaraju naduggar@microsoft.com

Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>
@mnltejaswini mnltejaswini requested review from sajayantony, etrexel and nathana1 and removed request for etrexel November 16, 2021 07:11
README.md Outdated Show resolved Hide resolved
cmd/ratify/cmd/resolve.go Outdated Show resolved Hide resolved
docs/store.md Outdated Show resolved Hide resolved
pkg/executor/core/executor.go Outdated Show resolved Hide resolved
pkg/executor/core/executor_test.go Outdated Show resolved Hide resolved
Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>
@mnltejaswini mnltejaswini merged commit 5f5cb9b into ratify-project:main Nov 17, 2021
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
* Added resolving  tag to digest as a method in the store interface

Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>

* Replaced ResolveTag with GetSubjectDescriptor

Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Tag to Digest resolution
2 participants