-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add examples for using AWS Signer #875
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 54.87% 54.87%
=======================================
Files 81 81
Lines 4798 4798
=======================================
Hits 2633 2633
Misses 1883 1883
Partials 282 282 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Byron Chien <byronc@ucla.edu>
2b2096a
to
2449c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks for the PR @byronchien , the content looks good to me! wondering if AWS Signer is the currently recommended approach , and if we should highlight that. @jimmyraywv , let us know if you have any feedback before we merge this. thanks! |
yes, using AWS Signer with notation on AWS is the recommended approach. |
Signed-off-by: Byron Chien <byronc@ucla.edu>
Description
What this PR does / why we need it:
Adds documentation on using Gatekeeper/Ratify to verify signatures with notation and AWS Signer.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #871
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change