Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart generated cert refers to helm release name in subject #885

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

fseldow
Copy link
Contributor

@fseldow fseldow commented Jun 16, 2023

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #886

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@fseldow fseldow changed the title bug - helm chart generated cert refers to helm release name in subject feat: helm chart generated cert refers to helm release name in subject Jun 16, 2023
@fseldow fseldow changed the title feat: helm chart generated cert refers to helm release name in subject fix: helm chart generated cert refers to helm release name in subject Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da42611) 54.87% compared to head (9ce9197) 54.87%.

❗ Current head 9ce9197 differs from pull request most recent head e1f17e6. Consider uploading reports for the commit e1f17e6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files          81       81           
  Lines        4798     4798           
=======================================
  Hits         2633     2633           
  Misses       1883     1883           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akashsinghal akashsinghal merged commit fb81a3f into ratify-project:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

untrusted cert when helm release is not ratify
4 participants