Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notary.crt to reflect latest sample #909

Merged

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Jun 29, 2023

Description

What this PR does / why we need it:

The current sample image is signed with a notation generated cert with a short expiry.
I ve resigned the image with 10 year cert now so we are good for the next 10 yrs..

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes # 910

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

time="2023-06-30T00:52:16Z" level=info msg="verifying subject ghcr.io/deislabs/ratify/notary-image@sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b"
time="2023-06-30T00:52:16Z" level=info msg="Resolve of the image completed successfully the digest is sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b"
{
"isSuccess": true,
"verifierReports": [
{
"subject": "ghcr.io/deislabs/ratify/notary-image@sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b",
"isSuccess": true,
"name": "notaryv2",
"message": "signature verification success",
"extensions": {
"Issuer": "CN=Ratify Sample,O=Ratify",
"SN": "CN=ratify.default"
},
"artifactType": "application/vnd.cncf.notary.signature"
}
]
}

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c6f7a2) 54.95% compared to head (ba5a554) 54.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          81       81           
  Lines        4791     4791           
=======================================
  Hits         2633     2633           
  Misses       1881     1881           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@susanshi susanshi changed the title Update notary.crt to reflect latest sample fix: update notary.crt to reflect latest sample Jun 29, 2023
@susanshi susanshi marked this pull request as ready for review June 30, 2023 00:57
@susanshi
Copy link
Collaborator Author

@luisdlp helped to delete the expired signatures, i ve validated the verification is passing now :) .PR is ready for review.

time="2023-06-30T00:52:16Z" level=info msg="verifying subject ghcr.io/deislabs/ratify/notary-image@sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b"
time="2023-06-30T00:52:16Z" level=info msg="Resolve of the image completed successfully the digest is sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b"
{
"isSuccess": true,
"verifierReports": [
{
"subject": "ghcr.io/deislabs/ratify/notary-image@sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b",
"isSuccess": true,
"name": "notaryv2",
"message": "signature verification success",
"extensions": {
"Issuer": "CN=Ratify Sample,O=Ratify",
"SN": "CN=ratify.default"
},
"artifactType": "application/vnd.cncf.notary.signature"
}
]
}

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for switching the cert!

@susanshi susanshi merged commit b7be0fb into ratify-project:main Jun 30, 2023
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants