Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable PA (de)rotation for (some) dual-corr modes #389

Open
o-smirnov opened this issue Jul 7, 2020 · 6 comments
Open

disable PA (de)rotation for (some) dual-corr modes #389

o-smirnov opened this issue Jul 7, 2020 · 6 comments
Assignees
@o-smirnov
Labels
bug

Comments

@o-smirnov
Copy link
Collaborator

PA [de]rotation of RR+LL data is a no-op, so it should just ignore itself.

PA derotation of XX+YY data is not well-defined and should throw an error.

The only dual-corr regime where I see any point bothering with PA is when we have a full-pol model (i.e. an LSM not a column), and we want to compute a rotated version of that to calibrate XX+YY data against. Derotation should still not be allowed.
@o-smirnov o-smirnov added the bug label Jul 7, 2020
@o-smirnov o-smirnov self-assigned this Jul 7, 2020
@o-smirnov o-smirnov mentioned this issue Jul 7, 2020
Closed
@IanHeywood
Copy link
Collaborator

I just saw the remark about this being a pointless memory guzzler. Is there an argument for it being disabled in the default parset?

@o-smirnov
Copy link
Collaborator Author

I guess there is. 99% of the time you're not doing polarimetry, right?

@IanHeywood
Copy link
Collaborator

100% of the time if I can get away with that.

@o-smirnov
Copy link
Collaborator Author

image

@IanHeywood
Copy link
Collaborator

100% of the time I expected that to be your "You may not be interested in the polarisation..." slide.

@o-smirnov
Copy link
Collaborator Author

That happens the other 100% of the time (which also explains CASA's flagging statistics...)

o-smirnov added a commit that referenced this issue Jul 9, 2020
@o-smirnov
fixes #390. Fixes #392. Disables PA rotation by default (see #389)
0eac7d3
JSKenyon pushed a commit that referenced this issue Jul 10, 2020
@o-smirnov
fixes #390. Fixes #392. Disables PA rotation by default (see #389) (#393
9561898 
)

* fixes #390. Fixes #392. Disables PA rotation by default (see #389)

* fixed direction=None case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o-smirnov o-smirnov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@o-smirnov @IanHeywood