feat(bundle.bbclass): simplify varflag usage #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ejoerns the second commit is to passing ci build, if required it can be cherry-picked to another branch to isolate the ci fix and drop from this branch history |
Jarsop
force-pushed
the
feat/simplify-varflag-usage
branch
from
1c4b176
to
1613794
Compare
|
@Jarsop Thanks! I have cherry-picked the CI fix on master (and slightly adapted the commit message). Feel free to rebase your PRs |
In many case `getVarFlag` is used but `slotflags` coming from `getVarFlags` previous call in bitbake task (`do_configure`) it's already expanded. This improvement use `slotflags`. It simplify also the loop over `RAUC_META_SECTIONS`. Signed-off-by: Jean-Pierre Geslin <jarsop@outlook.com>
Jarsop
force-pushed
the
feat/simplify-varflag-usage
branch
from
1613794
to
bb1145d
Compare
|
@ejoerns Perfect ! Did it. However it seems that |
|
The PR #291 update our |
|
This is no more relevant as I merged and adapted the content in #289. So I close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many case
getVarFlagis used butslotflagscoming fromgetVarFlagsprevious call in bitbake task (do_configure) it's already expanded. This improvement useslotflags.It simplify also the loop over
RAUC_META_SECTIONS.