Fix unhandled promise rejection when using markup #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method `location.output[index].set_use_markup` doesn't exist. But without the exception thrown by its use, the call to `location.output[index].set_text` overwrites markup settings. Ensure that only markup or normal text is set, but not both.
|
I took the liberty to remove some other unnecessary calls from the function to make it simpler. |
|
Thank you very much for creating this PR, it's very appreciated (and thanks for your patience!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
location.output[index].set_use_markupdoesn't exist.But without the exception thrown by its use, the call to
location.output[index].set_textoverwrites markup settings.Ensure that only markup or normal text is set, but not both.
Fixes #58