-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): allow using environment variables to set settings #186
Conversation
Switches to the figment configuration library, instead of doing everything manually
That's odd, the size reported in the artifact download is about .5 MB off from the actual downloaded size of the binary. |
Cleans up our code but adds significant dependency code. Do you think it's worth it? For config parsing, the benefit is obvious, but what is the benefit of using |
After (with size optimizations):
Honestly, now that I've done it, I'm not completely sure. I'll see the size comparison if I can find another config library that doesn't require |
Ah, and since
Well, I mean the size of the assets with size optimisations is lower than latest |
Originally I was using the Actually, the compressed size is a lot less than I thought it would be, still smaller than |
serde
and jsonwebtoken
instead of biscuit
Adds an actual configuration library, uses
serde
withoutserde_json
, and usesjsonwebtoken
instead ofbiscuit
. Increases binary size quite a bit, so now optimizes some packages for size instead of speed.