Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Project namespaces and organisation #7

Closed
damianh opened this issue Dec 18, 2012 · 9 comments
Closed

Project namespaces and organisation #7

damianh opened this issue Dec 18, 2012 · 9 comments

Comments

@damianh
Copy link
Contributor

damianh commented Dec 18, 2012

Raven.Client.Contrib should have it's default namespace as "Raven.Client" as that is the namespace it is extending. Thus when a user adds a reference to Raven.Client.Contrib package they will see the extensions in their intellisense without having to add a 'using Raven.Client.Contrib" directive.

The *Extensions types should be in matching namespaces that they extend. For instance, DocumentExtensions should be in a Connection folder and thus have namespace "Raven.Client.Connection". Again this helps discovery in intellisense.

Raven.Client.Contrib.Tests project default namespace should be Raven.Client (unit test classes don't have to be in a "Tests" namespace...)

@CMircea
Copy link
Contributor

CMircea commented Dec 18, 2012

Agreed.

@mattjohnsonpint
Copy link
Contributor

Ok, I wasn't sure on that, but I think it has merit. It will keep people's namespace imports simpler anyway. I forget not everyone likes ReSharper. :)

@mattjohnsonpint
Copy link
Contributor

Actually, I'm not sure that I agree for the Tests project. Raven's own test project uses the Raven.Tests namespace, and I know that various test runners have the option to group tests by namespace. It would probably be best to separate the contrib tests from the others. Yes?

mattjohnsonpint added a commit that referenced this issue Dec 18, 2012
@mattjohnsonpint
Copy link
Contributor

Changed for Raven.Client. Others can update their own areas if desired. It makes sense for client extensions, but I'm not sure it makes sense for other bits.

@damianh
Copy link
Contributor Author

damianh commented Dec 18, 2012

Ok, that's fine. The tests project is no biggie - Client one is more important.

@damianh
Copy link
Contributor Author

damianh commented Dec 18, 2012

Send a PR ( Issue #8 ) with proposed new organisation.

@mattjohnsonpint
Copy link
Contributor

looks good. will merge.

mattjohnsonpint added a commit that referenced this issue Dec 18, 2012
Issue #7 - Put extensions in same namespace as the types they are exteni...
@damianh
Copy link
Contributor Author

damianh commented Dec 18, 2012

Awesome, thx :)

@PureKrome
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants