RD-9528: slow phases #171
Merged
RD-9528: slow phases #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaidioz
force-pushed
the
RD-9528-slow-phases
branch
from
796d5f1
to
07aaab4
Compare
bgaidioz
force-pushed
the
RD-9528-slow-phases
branch
from
af9b8c7
to
6f3f6a1
Compare
bgaidioz
commented
Sep 6, 2023
raw-compiler-rql2/src/test/scala/raw/compiler/rql2/tests/regressions/RD9528Test.scala
Outdated
Show resolved
Hide resolved
bgaidioz
force-pushed
the
RD-9528-slow-phases
branch
from
6f3f6a1
to
22dcfed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bottom commit "initial setup for benchmarking" is changing log settings, some logging message level, and artificially multiplying phase rewrites with a loop. Also it adds a test that takes long to run because of the code size. We can probably remove that commit eventually. It's there for testing.
The fixes are in the commit after. They mostly use
Anyinqueryandeverywhere, wherever the profiler pointed us to. The left one creatingClassCastExceptionis noworg.bitbucket.inkytonik.kiama.relation.Tree$$anonfun$bottomupNoBridges$1.applyOrElse(Object, Function1).