Added new TypeScript description file. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great, thanks for your work! I never worked with TypeScript, so a silly question: Does the implementation work with ReadOnlyBitSet and the current BitSet.js implementation? |
|
And does the def file not need an entry in the package.json file? |
|
In TS the 'shape' is what is important not the inheritance structure. Therefore, the ReadOnlyBitSet should have the right 'shape' as the BitSet. However, we haven't tested it since I just added the interface a few days ago. If you could create a set of unit tests for it that would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the definition file we created. If you like great, if not that's okay too. However, if you see any issues with please let us know. Thanks.