Parent method intercept

[NaokiTsuchiya]

When the following class B is compiled, echo method could not be intercepted.

// A.php
class A
{
    public function echo(): void
    {
        echo 'echo';
    }
}

// B.php
class B extends A
{
}

// run.php
require __DIR__ . '/bootstrap.php';

$compiler = new Ray\Aop\Compiler(__DIR__ . '/tmp');
$bind = (new Ray\Aop\Bind())->bindInterceptors('echo', [new Ray\Aop\NullInterceptor()]);
$b = $compiler->newInstance(Ray\Aop\Demo\B::class, [], $bind);

// generated class
<?php

declare (strict_types=1);
namespace Ray\Aop\Demo;

use Ray\Aop\WeavedInterface;
use Ray\Aop\ReflectiveMethodInvocation as Invocation;
class B_1599363031 extends \Ray\Aop\Demo\B implements WeavedInterface
{
    public $bind;
    public $bindings = [];
    public $methodAnnotations = 'a:0:{}';
    public $classAnnotations = 'a:0:{}';
    private $isAspect = true;
}

In this PR, the following class is generated

<?php

declare (strict_types=1);
namespace Ray\Aop\Demo;

use Ray\Aop\WeavedInterface;
use Ray\Aop\ReflectiveMethodInvocation as Invocation;
class B_1599363031 extends \Ray\Aop\Demo\B implements WeavedInterface
{
    public $bind;
    public $bindings = [];
    public $methodAnnotations = 'a:0:{}';
    public $classAnnotations = 'a:0:{}';
    private $isAspect = true;
    public function echo() : void
    {
        if (!$this->isAspect) {
            $this->isAspect = true;
            call_user_func_array([$this, 'parent::' . __FUNCTION__], func_get_args());
            return;
        }
        $this->isAspect = false;
        (new Invocation($this, __FUNCTION__, func_get_args(), $this->bindings[__FUNCTION__]))->proceed();
        $this->isAspect = true;
    }
}

[codecov]

Codecov Report

Merging #181 (07824c7) into 2.x (1354004) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                 2.x      #181   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       165       168    +3     
===========================================
  Files             29        29           
  Lines            486       496   +10     
===========================================
+ Hits             486       496   +10     

Impacted Files	Coverage Δ
src/AopClass.php	100.00% <100.00%> (ø)
src/CodeGenMethod.php	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1354004...07824c7. Read the comment docs.

[koriym]

https://github.com/nikic/PHP-Parser/blob/master/doc/component/FAQ.markdown#how-can-the-parent-of-a-node-be-obtained

これを見落としてました、

この"parent"はノードの事でした！><

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

[SerjoA]

thank you for your hard and excellent work

[koriym]

@SerjoA Thank you for using Ray.Aop! cc/ @NaokiTsuchiya