Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #253

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Update README #253

merged 5 commits into from
Feb 8, 2022

Conversation

koriym
Copy link
Member

@koriym koriym commented Feb 6, 2022

  • PHP8.1のコードに対応
  • 最初から見直してクリーンアップ

@codecov
Copy link

codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #253 (52b606f) into 2.x (0c72dd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #253   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       317       317           
===========================================
  Files             36        36           
  Lines            819       819           
===========================================
  Hits             819       819

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c72dd5...52b606f. Read the comment docs.

NaokiTsuchiya
NaokiTsuchiya suggested changes Feb 7, 2022
View reviewed changes
README.ja.md Outdated Show resolved Hide resolved
README.ja.md Outdated Show resolved Hide resolved
NaokiTsuchiya
NaokiTsuchiya reviewed Feb 7, 2022
View reviewed changes
README.ja.md Outdated Show resolved Hide resolved
NaokiTsuchiya
NaokiTsuchiya reviewed Feb 7, 2022
View reviewed changes
README.ja.md Outdated Show resolved Hide resolved
koriym and others added 3 commits February 8, 2022 00:19
@koriym @NaokiTsuchiya
Update README.ja.md
36ae24a 
Co-authored-by: Naoki Tsuchiya <ntsuchiya1105@gmail.com>
@koriym @NaokiTsuchiya
Update README.ja.md
e3cea84 
Co-authored-by: Naoki Tsuchiya <ntsuchiya1105@gmail.com>
@koriym
Unify terminology from バインディング to 束縛
52b606f
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit aebdbdc into ray-di:2.x Feb 8, 2022
@koriym koriym deleted the readme branch February 8, 2022 14:24
@koriym
Copy link
Member Author

koriym commented Feb 8, 2022

@NaokiTsuchiya Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawanamiyuu kawanamiyuu Awaiting requested review from kawanamiyuu

@NaokiTsuchiya NaokiTsuchiya Awaiting requested review from NaokiTsuchiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koriym @NaokiTsuchiya