Emit prometheus metrics from kuberay control plane #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add kubernetes service for operators and backend service for scratching 2. Update ServiceMonitor to match service definiton 3. Add Grafana Dashboards for backend service and operators
|
I got two likes but no code review feedbacks.. Since this is straightforward, let me merge this and prepare the ready to use dashboard. If user has feedbacks later, feel free to cut new issue and mention me to look at it. |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Emit prometheus metrics from kuberay control plane 1. Add kubernetes service for operators and backend service for scratching 2. Update ServiceMonitor to match service definiton 3. Add Grafana Dashboards for backend service and operators * Fix golangci-lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is used to expose kuberay core component's metrics and it will help user to better monitor healthiness of the components.
Related issue number
Checks
Screenshots
Backend
Operator
