Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpu-accelerator in template #296

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

armandpicard
Copy link
Contributor

Why are these changes needed?

Related issue number

Closes #295

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jun 9, 2022

Thanks for the contribution. This is indeed a bug and the default should be nvidia.com/gpu and any given value should override the default settings.

@Jeffwan Jeffwan merged commit 7228732 into ray-project:master Jun 9, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] gpu-accelerator in template don't work
2 participants