Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose kubernetes events in apiserver #343

Conversation

scarlet25151
Copy link
Collaborator

Why are these changes needed?

In apiserver we would like to expose the events related to the raycluster for the observability, for now we can get the events directly from apiserver. However the events may be ephemeral, we would accept get events from other persistence storage in the future.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

proto/cluster.proto Outdated Show resolved Hide resolved
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Please address format and lint issue

apiserver/pkg/manager/resource_manager.go Outdated Show resolved Hide resolved
apiserver/pkg/server/cluster_server.go Show resolved Hide resolved
@scarlet25151 scarlet25151 force-pushed the enhancement/expose-kubernetes-events-in-apiserver branch 3 times, most recently from 56392ee to fdd678e Compare July 6, 2022 21:00
@scarlet25151 scarlet25151 force-pushed the enhancement/expose-kubernetes-events-in-apiserver branch from fdd678e to d03a4a2 Compare July 6, 2022 21:03
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jeffwan Jeffwan merged commit e3fa208 into ray-project:master Jul 6, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants