Support mounting volumes in API request #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
changed the title
Jeffwan
force-pushed
the
support_volume_apiserver
branch
2 times, most recently
from
eba8120
to
e4498bb
Compare
|
there are some conflicts we need to resolve |
Jeffwan
force-pushed
the
support_volume_apiserver
branch
from
e4498bb
to
17e7570
Compare
|
@wilsonwang371 I rebased the master and fix the conflicts. |
|
lgtm |
This change adds a new message Volume and adds parameters in HeadGroupSpec and WorkerGroupSpec message called volumes which allow user to specify a list of volumes. Based on the observation at https://kubernetes.io/docs/concepts/storage/volumes/, almost all mounting methods needs four params: name, mount path, source (this could be aws EBS volume id, hostpath, gce persistent disk name etc) and type (awsElasticBlockStore , hostPath, gcePersistentDisk etc.).
Jeffwan
force-pushed
the
support_volume_apiserver
branch
from
17e7570
to
65ecfb6
Compare
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Add volumes definition in proto file This change adds a new message Volume and adds parameters in HeadGroupSpec and WorkerGroupSpec message called volumes which allow user to specify a list of volumes. Based on the observation at https://kubernetes.io/docs/concepts/storage/volumes/, almost all mounting methods needs four params: name, mount path, source (this could be aws EBS volume id, hostpath, gce persistent disk name etc) and type (awsElasticBlockStore , hostPath, gcePersistentDisk etc.). * Add volumes in PodTemplateSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Rest API users need a way to mount volumes to ray cluster. We can extend the proto to support volumes.
Related issue number
Address #204
Checks