Enable DefaultHTTPErrorHandler and Upgrade grpc-gateway to v2 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiserver/cmd/main.go
Outdated
| @@ -4,14 +4,16 @@ import ( | |||
| "context" | |||
| "flag" | |||
|
|
|||
| "google.golang.org/protobuf/encoding/protojson" | |||
|
|
|||
There was a problem hiding this comment.
should run gofmt here.
| @@ -4,6 +4,8 @@ import ( | |||
| "context" | |||
| "fmt" | |||
|
|
|||
| "k8s.io/apimachinery/pkg/api/errors" | |||
|
|
|||
| "github.com/ray-project/kuberay/apiserver/pkg/model" | |||
|
|
|||
There was a problem hiding this comment.
nit: need to remove space here.
There was a problem hiding this comment.
this is some fmt issue that goimports and gofmt can not detect. that's why CI pass. I manually update the format and it also works
1. Enable `runtime.DefaultHTTPErrorHandler` to convert gRPC status code to HTTP code. 2. Since we use custom error struct, we need to implement `GRPCStatus` to make sure grpc-go can recognize the error code in our struct, Otherwise, it will always return codes.Unknown(2), that's the reason we always see code 2 and HTTP 500 in the past.
|
@scarlet25151 comments addressed. Please take another look |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…oject#369) * Upgrade grpc-gateway to v2 * Customize error and enable DefaultHTTPErrorHandler 1. Enable `runtime.DefaultHTTPErrorHandler` to convert gRPC status code to HTTP code. 2. Since we use custom error struct, we need to implement `GRPCStatus` to make sure grpc-go can recognize the error code in our struct, Otherwise, it will always return codes.Unknown(2), that's the reason we always see code 2 and HTTP 500 in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
#364
Checks