Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix raycluster updatestatus list wrong label #377

Conversation

scarlet25151
Copy link
Collaborator

Why are these changes needed?

The updateStatus method in reconcile was using wrong labels for the pods scraping.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Jeffwan Jeffwan added this to the v0.3.0 release milestone Jul 14, 2022
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 14, 2022

We found a state issue when head is pending and that's why this PR is raised.

@Jeffwan Jeffwan merged commit c3e0dd9 into ray-project:master Jul 14, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants