-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test files before separating them #591
update test files before separating them #591
Conversation
b7f0b10
to
c40b827
Compare
c40b827
to
72e6141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will rebase #589 after this PR be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch move some function to the utils, overall LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This is a patch that separate compatibility test into different files so that later we can only enable the necessary tests and delay other tests to nightly.
Why are these changes needed?
This is a patch that separate compatibility test into different files so that later we can only enable the necessary tests and delay other tests to nightly.
Related issue number
#514 #298
Checks