Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test files before separating them #591

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

wilsonwang371
Copy link
Collaborator

Why are these changes needed?

This is a patch that separate compatibility test into different files so that later we can only enable the necessary tests and delay other tests to nightly.

Related issue number

#514 #298

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will rebase #589 after this PR be merged.

Copy link
Collaborator

@scarlet25151 scarlet25151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch move some function to the utils, overall LGTM.

Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DmitriGekhtman DmitriGekhtman merged commit 80ac24b into ray-project:master Sep 27, 2022
@wilsonwang371 wilsonwang371 deleted the wilson/update_test branch September 27, 2022 20:07
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
This is a patch that separate compatibility test into different files so that later we can only enable the necessary tests and delay other tests to nightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants