[autoscaler] Expose autoscaler container security context. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Merged
4 tasks
kevin85421
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Thank @DmitriGekhtman for this contribution! We should create a namespace with restricted policies to test it. Follow the instructions in https://github.com/ray-project/kuberay/pull/750/files.
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
|
TODO: Try it in a namespace with restricted policies. |
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
|
@kevin85421 I just tested this with your securityContext instructions and it worked exactly as expected -- I was able to deploy a cluster and trigger autoscaling. |
kevin85421
reviewed
Dec 1, 2022
1 task
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ct#752) Expose configuration for the autoscaler container's security context. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com
Why are these changes needed?
Allows setting the autoscaler container's security context.
Related issue number
Checks