Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #10319 - Dashboard autoscaler crash #10323

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Fix Issue #10319 - Dashboard autoscaler crash #10323

merged 2 commits into from
Aug 30, 2020

Conversation

mfitton
Copy link
Contributor

@mfitton mfitton commented Aug 25, 2020

Why are these changes needed?

Please view the issue for more details. #10319

Related issue number

Closes #10319

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

Max Fitton added 2 commits August 25, 2020 11:16
Patch error that occurred when there was an entry in the dashboard lo…
446c1aa 
…gs or errors internal data structures, and a worker was removed from the cluster. This would crash the cluster with a KeyError.
lint
81ed170
@mfitton mfitton added bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard labels Aug 25, 2020
@rkooo567
Copy link
Contributor

Any way to add tests for this? (maybe using cluster_utils)? Do you think it is not worth it because we will move onto the new backend?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 25, 2020
@rkooo567
Copy link
Contributor

@mfitton I will just merge it because we will turn on the new dashboard very soon. But please write the test scenario for this case and add it to the new dashboard in the future!

@rkooo567 rkooo567 merged commit 63ad2e3 into ray-project:master Aug 30, 2020
@mfitton mfitton deleted the dash_log_bugfix branch August 31, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@edoakes edoakes Awaiting requested review from edoakes

Assignees

@rkooo567 rkooo567

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dashboard] When autoscaler adds/removes worker, dashboard crashes
2 participants
@mfitton @rkooo567