Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken gcs restart test. #10417

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Fix broken gcs restart test. #10417

merged 2 commits into from
Aug 30, 2020

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented Aug 29, 2020 •
edited
Loading

Why are these changes needed?

Seems like it is broken because wait only accepts kwargs now.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@rkooo567 rkooo567 merged commit 3e5cac8 into ray-project:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkooo567 @ericl