Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] update scripts.py invalid invocation #10425

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

richardliaw
Copy link
Contributor

@richardliaw richardliaw commented Aug 30, 2020

Why are these changes needed?

==> /tmp/ray/session_2020-08-30_01-47-33_393277_81299/logs/monitor.out <==
Traceback (most recent call last):
  File "/home/ubuntu/anaconda3/bin/ray", line 8, in <module>
    sys.exit(main())
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/ray/scripts/scripts.py", line 1600, in main
    return cli()
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/ray/scripts/scripts.py", line 465, in start
    address, redis_address)
TypeError: validate_redis_address() takes 1 positional argument but 2 were given

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@richardliaw richardliaw changed the title [hotfix] update scripts [hotfix] update scripts.py invalid invocation Aug 30, 2020
@richardliaw richardliaw requested a review from ericl August 30, 2020 01:50
@rkooo567 rkooo567 merged commit 8c75381 into ray-project:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants