-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray SGD] LightningModule integration + MNIST Example #11042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good; good work!
can you add some unit tests and address comments?
amazing!! I haven't had a chance to pull and try this out but @amogkam do you know if the following work with PTL x RaySGD?
we might also want to add a sentence describing whether any functionality is lost to the docs PR |
@sumanthratna Thanks for the comment- let me know how it goes if you plan to try it out! This will have all the same functionality as standard Ray SGD so there is mixed precision support with Nvidia Apex. But Pytorch native mixed precision, auto batch size tuning, and auto lr rate tuning are not supported yet. These are probably good next steps to work on. And yep, I have a list of all features that we currently don't support and will add it to the docs :) |
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good; ping when tests pass?
@richardliaw travis passing, should be ready to merge |
Docs to come later
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.