-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray SGD] Support num_steps continue training #11142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one comment about test.
Does this all get reset when there are changes in worker pool?
Yes that's a good point. This does get reset whenever the worker pool size changes. I'll raise an issue for this, but I think it requires some more thought on how to handle this. |
@richardliaw finally...tests are passing |
Currently, when training or validating with num_steps parameter set, each call will reset the data loaders from the beginning. This PR makes sure that subsequent training or validation calls consumes the entire data loader before resetting it. Also provides functionality to automatically cycle around the data loader if we still need to do more steps of training or validation.
Why are these changes needed?
Related issue number
Closes #8907
Checks
scripts/format.sh
to lint the changes in this PR.