[SGD] Callback API for SGD+Tune #11316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Oct 10, 2020
richardliaw
reviewed
Oct 10, 2020
richardliaw
reviewed
Oct 10, 2020
richardliaw
reviewed
Oct 10, 2020
richardliaw
reviewed
Oct 10, 2020
| @@ -678,6 +715,7 @@ def step(self): | |||
| train_stats = self.trainer.train(max_retries=10, profile=True) | |||
| validation_stats = self.trainer.validate(profile=True) | |||
| stats = merge_dicts(train_stats, validation_stats) | |||
| self._iter += 1 | |||
There was a problem hiding this comment.
Is this state supposed to be saved upon checkpoint?
There was a problem hiding this comment.
Ah yes good catch. Added it to save_checkpoint and load_checkpoint.
There was a problem hiding this comment.
Actually, now I know what you're doing here, I think we already provide self.training_iteration in trainable, so you don't actually need to save/manage this stuff.
There was a problem hiding this comment.
Ah got it. Changed it to using self.training_iteration and removed the duplicate metadata checkpointing.
richardliaw
reviewed
Oct 10, 2020
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
|
@richardliaw Yes I ran it by Richard (Dendra) and he said he really liked it. |
richardliaw
reviewed
Oct 13, 2020
richardliaw
reviewed
Oct 13, 2020
richardliaw
reviewed
Oct 13, 2020
richardliaw
requested changes
Oct 13, 2020
richardliaw
added
the
@author-action-required
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
amogkam
removed
the
@author-action-required
richardliaw
reviewed
Oct 15, 2020
richardliaw
reviewed
Oct 15, 2020
richardliaw
reviewed
Oct 15, 2020
richardliaw
reviewed
Oct 15, 2020
|
|
richardliaw
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation updates to come later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.