Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] re-enable serve-controller-crash test #11579

Merged
merged 8 commits into from
Nov 2, 2020
Merged

[serve] re-enable serve-controller-crash test #11579

merged 8 commits into from
Nov 2, 2020

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Oct 23, 2020

Why are these changes needed?

  • These tests were disabled a while back, re-enabling them now!

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Oct 27, 2020 •
edited
Loading

@simon-mo @edoakes
Hmm, these tests same flakey--They seem more likely to be flakey on Travis than locally

//python/ray/serve:test_controller_crashes                                FLAKY, failed in 2 out of 3 in 915.0s

This has actually been fixed I think!

simon-mo
simon-mo approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/ray/serve/BUILD Show resolved Hide resolved
python/ray/serve/tests/conftest.py Show resolved Hide resolved
python/ray/serve/tests/test_api.py Show resolved Hide resolved
@ijrsvt
Copy link
Contributor Author

ijrsvt commented Oct 29, 2020

Some flakiness may be seen because of #11683

@simon-mo simon-mo merged commit 171e02c into ray-project:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@edoakes edoakes

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijrsvt @simon-mo @edoakes