Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] More PTL example cleanup #11585

Merged
merged 2 commits into from
Oct 26, 2020
Merged

[tune] More PTL example cleanup #11585

merged 2 commits into from
Oct 26, 2020

Conversation

richardliaw
Copy link
Contributor

Why are these changes needed?

Pytorch Lightning example cleanup.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw
update-example
84d8a04 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
Merge branch 'master' into update-example
6d4285a
krfricke
krfricke approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating.

@richardliaw richardliaw merged commit 4ad8af9 into ray-project:master Oct 26, 2020
@richardliaw richardliaw deleted the update-example branch October 26, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardliaw @krfricke