-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Add the new dashboard code and prompt users to try it #11667
Conversation
I don't understand the title of this PR. @mxz96102 Are you trying to enable the new dashboard by default? |
@mxz96102 How about changing the title to "[Dashboard] Add the new dashboard code and prompt users to try it"? |
@mfitton Is there anything wrong with this pr? Please review and let me know if there is~ |
@raulchen @mxz96102 I just tried this out, but it seems that the jobs, actors, and logs pages are not working.
|
This may due to code sync, I didn't update the backend code with this branch. Now I merged the master, these problems are supposed to be solved now. |
Thanks @mxz96102 I'll take another look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxz96102 @raulchen it seems to be working now!
I'm ok to merge this with the following change: can we place change the naming of the buttoms from "TRY NEW DASHBOARD" to "TRY EXPERIMENTAL DASHBOARD" and "BACK TO LEGACY" to "BACK TO EXISTING DASHBOARD"? I'd also like it if we could remove the "SUMMARY" page entirely as it's basically just a blank screen right now.
I have a bunch of other small feedback on how we can improve this dashboard before we ask for feedback from OSS users. I will file this under a github milestone in the couple of days.
@edoakes Thanks, I'm glad to have feedback with your team, it's important that we can hear your opinion and improve dashboard together |
…y it (ray-project#11667)" This reverts commit c536c4d.
Why are these changes needed?
Immigration of the ant new dashboard, like we talking about last week.
The old dashboard is also maintained inside, we will remove it once everything is ready.
The old dashboard connects with the new one with a link.
Instead of using change origin, using package.json proxy to connect API server to backend
Related issue number
#10018
Checks
scripts/format.sh
to lint the changes in this PR.