Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] Support empty node list for kill node #11810

Merged
merged 3 commits into from
Nov 5, 2020
Merged

[autoscaler] Support empty node list for kill node #11810

merged 3 commits into from
Nov 5, 2020

Conversation

richardliaw
Copy link
Contributor

@richardliaw richardliaw commented Nov 4, 2020 •
edited by amogkam

Why are these changes needed?

Kill nodes for autoscaler.

Related issue number

Closes #9923

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw
avoid-nodes
f9cd532 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
amogkam
amogkam approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@richardliaw
optional
48f5bbb 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
8dae3ae 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw richardliaw merged commit f6717b8 into ray-project:master Nov 5, 2020
@richardliaw richardliaw deleted the avoid-worker-death branch November 5, 2020 06:40
@wuisawesome
Copy link
Contributor

thanks, (also pls ping me/add these to the spreadsheet for cherry-picking in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tune] Long running distributed test failing
3 participants
@richardliaw @wuisawesome @amogkam